i have pr opened 2 weeks ago and no one reivews it but if the manager says that this pr is important in the group chat then everyone starts to review it. you cannot merge the code unless someone approves it. i just joined the company for 1 month. now really considering leaving.
- Try to get to know how the review and change control process is .. usually your manager should tell you this in your 1:1. - If he forgot then ask him. - Check previous slack messages if you use slack to see how others have got their prs reviewed. - check with teammates in standup
This is a nice post on blind. Questions like this are necessary. I have had occasions where I had to beg ppl to review it. Typically ask your manager about what’s the process ?
Hmm do they get emails when your open your PR? It not- request their review directly. Do you have a team channel? When you make a PR, ‘@‘ the person you think has the most context. Maybe the tech lead. Also ‘@‘ the oncall
Give them a deadline. Review this by X otherwise it is getting pushed!
Post in the slack group channel asking for the review.
Not sure how this works in your team, but sending PR to a specific person usually works better than sending it to a generic team-wide channel.
Thank you, our team of qualified trolls will reply your inquiry in a short manner
Make sure you ask people personally to review the PR otherwise they will just assume/hope someone else will review it and they don't need to use their time to do it.
+1 facing the same situation. After a few occurrances, I am now tagging that person on the group chat with link to the pull request. Now my requests are addressed within a couple of hours. Also, make sure your code isn't too long when you open a pull request. It should ideally be one day's worth of coding.. Here's where I learnt it from: https://www.joelonsoftware.com/2000/08/09/the-joel-test-12-steps-to-better-code/ The Joel Test: 12 Steps to Better Code – Joel on Software
Typically try to bring it up in stand-up, usually helps to mention it then, and then follow up personally with a few people on your team. That way you can inform people you are blocked, plus you remove the bystander effect.
This! good one to go with.
Good advice, with one nit. Bring it up during stand up, but don't name names. (As in, "my PR has been out for review for n days now, and I'll appreciate it if someone can take a look soon" as opposed to "I have sent a PR to Bob n days ago and he still hasn't reviewed it.")