How do you deal with people who put large amounts of trivial comments on git pull requests? They block merges for over a week exclusively for issues that range from "args is an abbreviation and breaks style guides" to complaining that office printer setup instructions don't belong in laptop onboarding documents.
Walk up to his/her desk. Figure out what he wants you to do and why. Smile and say ok. Then ask if he is ok with everything else. Then go back to your desk, make the changes and push. Ask him to approve. It's faster to deal with people like that in person, just my opinion.
The trivial stuff is annoying I agree - but most of it can be documented and people stop making those mistakes. For me, the best is when itâs an isolated piece of code that has no chance of being reused elsewhere and someone makes all of these obvious best practice comments that support solid design principles and shit. Then you spend 3 more dev days bloating the shit out of an app that has one purpose. And (shockingly) you never touch it again.
Tell them to be reasonable if it goes on for a while tell them again. Lastly talk to your manager. If you are the manager tell them again. Try to monitor weather this goes on just in your PRs or the same thing happens with others. How do others handle that?
Blocking for style seems silly and counterproductive when you have deadlines to meet. OTOH habitually making the same mistake reflects poorly on you because it demonstrates that you are either not absorbing or are ignoring feedback.
There were 2 ppl like that in my team. Unless you had a personal chat with them it was impossible to get unblocked. I think they just lacked social interactions and sought them through PRs
Thatâs why code review sucks most of the time.
Don't break style guidelines
Those style stuff should be automatically caught by Style Cop and ideally human just need to comment on the logic.
Integrate linter / style checker with your IDE so you catch mistakes before commit. Run appropriate linter / style enforcer for your language as a CI job. Donât request review until itâs passing. Over time both of these will help you to write cleaner code.
2024 Presidential Election
Yesterday
2258
Biden ruined America and tech! Tax plans are insane
Tech Industry
Yesterday
1771
So hard being a women in tech industry
Tech Industry
Yesterday
624
Chances of meta clearing E5 with screwing up one coding one round and acing all other
Tech Industry
2d
53868
Goog Employees Arrested
Layoffs
2d
41690
Google CFO confirms 'large-scale' layoffs (Apr 17)
You donât have to address all of the comments
Then they'll just keep blocking it
Reset their feedback