NvidiađŸ’©â—

Pull Request comments

How do you deal with people who put large amounts of trivial comments on git pull requests? They block merges for over a week exclusively for issues that range from "args is an abbreviation and breaks style guides" to complaining that office printer setup instructions don't belong in laptop onboarding documents.

Add a comment
Microsoft _l0_l Jul 19, 2018

You don’t have to address all of the comments

Nvidia đŸ’©â— OP Jul 19, 2018

Then they'll just keep blocking it

Microsoft Tier 1 Jul 19, 2018

Reset their feedback

Tesla LEETCODER Jul 19, 2018

Walk up to his/her desk. Figure out what he wants you to do and why. Smile and say ok. Then ask if he is ok with everything else. Then go back to your desk, make the changes and push. Ask him to approve. It's faster to deal with people like that in person, just my opinion.

Amazon xCCNcx54 Jul 19, 2018

The trivial stuff is annoying I agree - but most of it can be documented and people stop making those mistakes. For me, the best is when it’s an isolated piece of code that has no chance of being reused elsewhere and someone makes all of these obvious best practice comments that support solid design principles and shit. Then you spend 3 more dev days bloating the shit out of an app that has one purpose. And (shockingly) you never touch it again.

Capital One SKUh72 Jul 19, 2018

Tell them to be reasonable if it goes on for a while tell them again. Lastly talk to your manager. If you are the manager tell them again. Try to monitor weather this goes on just in your PRs or the same thing happens with others. How do others handle that?

Microsoft VlCX25 Jul 19, 2018

Blocking for style seems silly and counterproductive when you have deadlines to meet. OTOH habitually making the same mistake reflects poorly on you because it demonstrates that you are either not absorbing or are ignoring feedback.

Microsoft anon_y Jul 19, 2018

There were 2 ppl like that in my team. Unless you had a personal chat with them it was impossible to get unblocked. I think they just lacked social interactions and sought them through PRs

Revinate je82id6 Jul 19, 2018

That’s why code review sucks most of the time.

Microsoft Qodjvueheb Jul 19, 2018

Don't break style guidelines

Microsoft XAgT42 Jul 19, 2018

Those style stuff should be automatically caught by Style Cop and ideally human just need to comment on the logic.

GitHub Uhe Jul 19, 2018

Integrate linter / style checker with your IDE so you catch mistakes before commit. Run appropriate linter / style enforcer for your language as a CI job. Don’t request review until it’s passing. Over time both of these will help you to write cleaner code.