Your teammate approves bad code and it gets merged. What do you do?
Teammate merged some bad code yesterday. I just read the PR and it’s pretty bad. Basically repeated the same code for each model type on each view. God damn. These rubberstamp ✔️🤦♂️
Do the needful and revert back
Sorry for not being kindly
No problem. You did the needful.
Open an issue and add branch policies to be set as a required reviewer the next time
There are code inspection tools that will detect duplicated code and classify them as tech debt. The tech debt stats would allow you to justify complaining about the code.
Actually, you should have this static code analysis as a pre-checkin rule.
Most source control tools like github and fecru can have the default changed from 1 sign off to multiple. Also, it may be worth it to enforce a time limit like 5 days or more to give people ample time to review it. You should definitely have a team discussion about this so you don't have a new employee approving a pr they don't understand, and the requester merging bad code because "it was approved". And uh, if there's no tests for the code, it sounds like you may have more on your plate in the future. (require code changes to be covered, part of the definition of "done", etc... ) Good luck op
As long as the test suite runs fine, no need to worry. Just give an honest and light suggestion to the person for next time.
We have no tests for this code.
I felt so dirty saying that.