I joined this team recently and did a code review for a senior engineer.
One of the methods they introduced is written badly. I left some feedback to optimize which got ignored. They made one other minor change i suggested but the other bad code was sent back as is.
Should I pushback or just give a sign of & fix it myself? I mean it works but its doing extra iterations and variable assignments etc for no reason at all.
The senior engineer is nice to talk to and have been respectful most times, so I am confused why they chose to ignore. And how do I give feedback if not via code review comments?
#tech #codereview
Want to see the real deal?
More inside scoop? View in App
More inside scoop? View in App
blind
SUPPORT
FOLLOW US
DOWNLOAD THE APP:
FOLLOWING
Industries
Job Groups
- Software Engineering
- Product Management
- Information Technology
- Data Science & Analytics
- Management Consulting
- Hardware Engineering
- Design
- Sales
- Security
- Investment Banking & Sell Side
- Marketing
- Private Equity & Buy Side
- Corporate Finance
- Supply Chain
- Business Development
- Human Resources
- Operations
- Legal
- Admin
- Customer Service
- Communications
Return to Office
Work From Home
COVID-19
Layoffs
Investments & Money
Work Visa
Housing
Referrals
Job Openings
Startups
Office Life
Mental Health
HR Issues
Blockchain & Crypto
Fitness & Nutrition
Travel
Health Care & Insurance
Tax
Hobbies & Entertainment
Working Parents
Food & Dining
IPO
Side Jobs
Show more
SUPPORT
FOLLOW US
DOWNLOAD THE APP:
comments