How to give feedback to a senior engineer ?

Apple
eijun

Go to company page Apple

eijun
Feb 24 8 Comments

I joined this team recently and did a code review for a senior engineer.

One of the methods they introduced is written badly. I left some feedback to optimize which got ignored. They made one other minor change i suggested but the other bad code was sent back as is.

Should I pushback or just give a sign of & fix it myself? I mean it works but its doing extra iterations and variable assignments etc for no reason at all.

The senior engineer is nice to talk to and have been respectful most times, so I am confused why they chose to ignore. And how do I give feedback if not via code review comments?

#tech #codereview

comments

Want to comment? LOG IN or SIGN UP
TOP 8 Comments
  • Meta
    iCCc25

    Go to company page Meta

    iCCc25
    left comment: is this addressed ? Whatโ€™s your thought about it.
    Feb 24 0
  • Meta
    โ›“

    Go to company page Meta

    โ›“
    1:1 dialogue is best. Surface as a question to genuinely learn their perspective. If they are not reasonable, there is likely something else at play - but most likely they are moving fast and not communicating more than being intentionally reckless.
    Feb 24 0
  • Amazon
    rcjj

    Go to company page Amazon

    rcjj
    Is it an insignificant nit? Is what they wrote conducive to more readable code than what you're suggesting?
    Feb 24 0
  • Autodesk / Eng
    Bedj02

    Go to company page Autodesk Eng

    Bedj02
    Push back, but gently. The point of code review is collaboration. If I were in your position my next move would be to ask them "What did you think of this other suggestion?" Just a simple clarifying question with no value judgment in it that invites a direct response.
    Feb 24 0
  • If you feel like a comment NEEDS to be addressed then request changes instead of commenting. That will stop the PR from moving. I do this all the time with code smells.
    Feb 24 0