Our team has two weeks sprint, before this sprint started, one of my colleagues , called it A, he first asked me Did I finish all my tickets in last sprint, I told him yes. Then At the same day I saw he talked with B who is project lead in private, also separately with manager. Next day, before new sprint plan meeting, B told me I should reduce my planned tickets , blamed me “you always pull too much work and you cannot finish “, seriously ? Is that me or A? i was upset at that moment but I did not say anything. So I reduced to two tickets, but B is ok A have six tickets. During next two weeks, I completed one ticket using three days , sent out my change for review on Monday , got reviewed and enough ships on Wednesday, When I was about to push my change, A started to ping me, said he wants to take a look at my change, asked me we should allow two person reviews for big change, I agreed. So I waited until today it has been three business days passed , everyday I kept asking A to review my changes, today I asked a few times , whenever I dropped by his desk, he told me He ‘s looking at it, I saw him reviewed other code that just sent out today , he is also helping to research some solutions of other people ticket. Those stuff are not urgent, But my change is there for 1.5 weeks and blocks other tickets. Development is taken 3-4 days for one big change, but reviews took double time in the same team!? Consider what happens before and after sprint, I feel like my code get held by A on purpose. First he complained to project lead and manager I assigned too much tickets myself I cannot finish , which it’s not true. Then try to hold my code change, so I can not mark it completed in current sprint. No mention several times I communicated with him, I feel like he play dumb and unwilling to discuss and listen. I plan to talk to my manager about this, want to know any suggestion here ?
You feel you are not sure, maybe your code will blow up, be patient and nice try to set up a meeting with him to go over your changes so it can be approved faster.
That’s what I planned, setup a meeting with him to review together. My code has been reviewed and approved by other colleagues, so it shouldn’t have big issue. This is second time , I don’t want this happens every time.
If you are sure bring it with your manger at 1:1.
somehow this story makes me feel sad.
How about calling code review delays out during retro without naming anyone till asked specifically? That will scare him off... of it doesn’t then send weekly gentle reminders to him with manager in loop...
Tbh, it’s common issue in our team. Code review delays has been raised up by others in the retro meeting. Manager promised to do something next quarter. I probably just let it go if he did not do extra stuff except slow review Yes, like to bring this topic again in the retro
Don’t spend time fixating on the amount of tickets you complete in a sprint. That’s not a measure of your impact. If your work is done, wait for review. Ping reviewers regularly to remind them to review your code, the rest is outside your control. If a senior engineer asks not to merge something and wants to review it, that’s not unheard of. They may take time to review it and become a blocker. That happens. The reason you were called out on assigning too many tickets to yourself might be because you like to complete all of them at the end of the sprint and expect your team to review huge chunks of code. During stand ups and sprint reviews, make sure to point out that your work is complete and you are blocked by reviewers. If schedule is important, the team usually accommodates the reviewers (quicker reviews, more forgiving of tech debt, etc). If you are not on a tight schedule, you might have to wait. Are you a good code reviewer yourself? Reviews go both ways. If you never give quick reviews or just incapable of good feedback, you will have hard time getting your changes reviewed. Break the tickets into smaller tasks and make it super easy for colleagues to review changes (the smaller, the better). If you genuinely believe that you do everything right, but you just happen to work in a team if assholes, just look for another job/team.
Clear cut politics... be upfront about it and discuss with your manager... Though I’m not very hopeful that manager will help you if he has a better repport with the other guy... in that case u should immediately slow down your work and start planning a team change...