A recent senior hire has screwed up the code base that I view as my baby...I basically introduced a new framework. Another developer (friend) and I built out the framework and we set our own standards and conventions to do things. We have proof of concepts currently in production and we have demonstrated these ideas to the team. The recent hire started working on a project also using our new framework... But he's gone off the rails and used conventions completely different and not necessarily better than what is established. There's a lot of unnecessary shit in the codebase now. He didn't even consult with anyone about this even though there had been multiple attempts to help. Somehow the code's been merged into the main branch without a CR. What should I do? UPDATE: Found out that the recent hire is getting PIPed. Perfect. I didn't need to do anything. Thank you Amazon for being fair.
Just talk to him, work togather!
I'll try again...
Hehe
Yeah dude... Unfortunately we move fast. We don't have time like that. It's also a big piece of code. Also I get nothing by doing the rewrite myself. This is expected to have been done correctly from the start. Everyone else has gotten the memo though hours of demo and discussion. This is no excuse. Think about it. If there's something unfamiliar to you in the code base 1. You consult and ask for directions and 2. Seek out code review. He did neither. He a senior in the industry. I expected better...
> gets mad at bad code > doesn’t do code review 🤮🤮
Do you not have code reviews?
In your initial posing you said the code is like your baby and your friend helped you write it. It seems like you're just too attached to the work you did. What if tomorrow react native goes away and you're asked to tear down all of that work to accomodate some new tech? Or what if someone other then you I'd asked to do it? Secondly I see process issues too, for example you say you move too fast to spend time teaching people the right way to do things. Also maybe the task was a little too big for a new hire of 5 months? Unless this is the first time you're onboardjng a new hire, I think there's work to do on the team's part. Then you can coach the new hire.
I am actually completely fine with React getting scraped. While I understand that i could possibly be a bit attached, I'm more concerned that we have multiple ways to do something in the code base. We have inconsistencies that could've been avoided if the engineer used common sense.
It sounds like he/she may be inexperienced with design. My point is that before blaming someone else (that too a new hire), the team should try to see what they can do to prevent this (ie. Scale down tasks given to a new hire. Have better documentation, mentoring etc...). Once you figure this out, have a talk with the new hire about the issue. Start off with what you guys will do to prevent this from happening then tell him/her what they can do (asking for help, getting a design doc out for review...).
1 you have coworkers; you don't have a baby 2 if you don't have processes in place for new hires to be successful, then don't hire 3 how do you expect the talk with your manager to go? It sounds like "I hate my team they use tabs instead of spaces"
OP whether you like it or not, you share responsibility for what happened. If you just wanted to vent, Blind is not the place, you should share with Mom. Peace.
Fk your baby shit. Why the fk did u not review if it’s so important to u. You are the idiot here not the new hire
There was NO review you idiot. Go back and read the post again.
Whenever possible, enforce these in your build pipeline to maintain consistency n prevent damages. Having said that, few things: - you mentioned about setting your own standards and conventions. Why so? Does not your company already have a set of guidelines already established? - I understand that you n your frnd laid the foundation, however, do not get emotionally attached to it and move on.
OP getting flamed 😂
Revert it and ask why it got approved. Educate the team instead of be mad