aws new employee - thoughts

May 20, 2019 60 Comments

just joined AWS 2 weeks ago as sde 1. i thought since its AWS I'd probably be working with smart people. I come from wayfair, which pretty much has the worst eng culture and thought may be if I join AWS, I will get to work with people who know what they are doing. I started code reviewing - folks are pushing out code with 40 intermediate commits with some horrendous commit messages. I suggested to squash commits as not all commits are important and keep the git history clean to only important commits. sde-2s suggesting me it does not matter.

what did I get myself into? have to start leetcoding again now. damn. incompetence just oozing everywhere.

TC 196K

comments

Want to comment? LOG IN or SIGN UP
TOP 60 Comments
  • Amazon Oggy
    I mean honestly, this is why you're SDE1. Git pretension is the fucking worst- as if squashing commits is a proxy for intelligence.
    May 20, 2019 13
    • Amazon slang
      Haha holy shit, what the fuck are those last 4 fortune cookie programming insights? Go deeper? Value the small things? Be the change? OP is 12 yoe. Wait, no 12 yo.
      May 21, 2019
    • Wayfair pbSy87
      OP
      @slang a brand new stock of bananas just arrived. run, this is your only chance.
      May 21, 2019
  • Amazon gdxi4nd
    Welcome to Amazon!
    May 20, 2019 0
  • Zillow Group o-/-<
    You are going to be squashed
    May 20, 2019 9
    • Microsoft UMbR31
      Can't wait for Blind to get hacked, only to reveal uslag is OP's L8 :)
      May 20, 2019
    • Wayfair pbSy87
      OP
      that's should be the least of your concerns - if blind were to get hacked
      May 20, 2019
  • Amazon citasec
    We squash on merge...
    May 20, 2019 3
    • Wayfair pbSy87
      OP
      this is good, usually tools like gitlab have that as part of tooling
      May 20, 2019
    • Amazon citasec
      The CRUX tool let’s you fast forward or summary commit (squash). My team does the latter. I don’t see why you can’t do that either OP? What’s the problem
      May 20, 2019
  • Amazon / Eng
    fahrenheit

    Amazon Eng

    PRE
    Zalando
    BIO
    Amazon SDE2 in Berlin
    fahrenheitmore
    Really? Of all the bullshit that goes on in Amazon in the technical space, you're concerned about fucking Git history?

    You don't mention the constant churn of deprecation, the ancient tooling, the management by panic, the suffocating weight of legacy, the bureaucratic mess of escalation, the ridiculous level of unnecessary complexity in the service spaghetti, the proliferation of integration at the persistence layer, the awful close coupling of everything to every other thing, the fact that using AWS in Amazon is rare except for a couple of services and autoscaling is not really a thing, the immature and dogmatic approach to database technology, the fad-driven architecture, the abandoned horrible projects that were only set up to get someone promoted but drive enormous risk, the ancient intern projects that grew like fungus into org-wide technical cornerstones with zero planning and now cause pain for thousands of engineers for no good reason.

    No, you care about Git history hygiene.

    Grow up.
    May 20, 2019 6
    • Amazon / Eng fahrenheit
      Commercial, Digital and Other. It basically means "not AWS" in everyday parlance. I don't know if it's strictly true (I imagine things like Legal are neither AWS nor CDO) but AWS and CDO pretty much cover the parts of Amazon that SDEs need to think of, as far as I understand.
      May 20, 2019
    • Amazon slang
      In every team I've ever been on, the guy who starts contentious code reviews over linting / config / tabsVspaces / Git history etc. Has always been the least mature and least effective. OP just confirming this observation again.
      May 21, 2019
  • Intuit what!
    Walk that developer through a scenario when he would need to revert a change back because of a major bug. How would they go about doing that?

    Also, I believe you are new so no one will listen to you. Spend some more time in the team and then try bringing it up again.

    I am generally surprised about how many engg teams undermine the importance of right branching model and clean git history
    May 20, 2019 0
  • Google / Eng blahhalb
    In Amazon, it all depends on how smart are the seniors engineers/managers. Everyone is super burnt out so nobody in amazon cares about small things. Wait for some time and you will see the kind of hacks devs have put in code. AWS is the worst place to work. Let me know if you need a google referral.
    May 20, 2019 4
    • Wayfair pbSy87
      OP
      The correct grammar would be - that does not surprise me at all. Looks like you are from the country that shall not be named.
      May 21, 2019
    • Amazon slang
      @pbSy87 I would really, really love to hear which country you think I’m from.
      May 22, 2019
  • Rally Health FuPayMe$$$
    Who the fuck cares about the codebase as long as the tc is good?! Make your goddamn money and enjoy life.
    May 20, 2019 1
    • Oscar 🐨koala
      ?? Because when you need to be oncall you have to unfuck your shits.
      May 20, 2019
  • Medallia / Eng ouie
    $196 TC and complaining about git commit messages? And we think there isn’t a huge bubble in tech...
    May 21, 2019 0
  • Oscar 🐨koala
    Lol
    May 20, 2019 0

Salary
Comparison

    Real time salary information from verified employees