I was working on unit test today and realized I needed to do something I had done before in another unit test. I went reference it and maybe move it to a common function and discovered someone else had replaced it with something nonsensical.
I can't share the exact code obviously, but it essentially a for loop controlled by magic numbers that allocates an object into a global variable inside the loop then overwrites the pointer on the next iteration. I think it's a typedef of a shared pointer, so it might just barely not be a memory leak.
I wondered how this got through code review, so I looked and it was some > 1,000 line change by someone from another team. However, 2 people from my team gave this change approval.
What?
TC 180K
Want to see the real deal?
More inside scoop? View in App
More inside scoop? View in App
blind
SUPPORT
FOLLOW US
DOWNLOAD THE APP:
FOLLOWING
Industries
Job Groups
- Software Engineering
- Product Management
- Information Technology
- Data Science & Analytics
- Management Consulting
- Hardware Engineering
- Design
- Sales
- Security
- Investment Banking & Sell Side
- Marketing
- Private Equity & Buy Side
- Corporate Finance
- Supply Chain
- Business Development
- Human Resources
- Operations
- Legal
- Admin
- Customer Service
- Communications
Return to Office
Work From Home
COVID-19
Layoffs
Investments & Money
Work Visa
Housing
Referrals
Job Openings
Startups
Office Life
Mental Health
HR Issues
Blockchain & Crypto
Fitness & Nutrition
Travel
Health Care & Insurance
Tax
Hobbies & Entertainment
Working Parents
Food & Dining
IPO
Side Jobs
Show more
SUPPORT
FOLLOW US
DOWNLOAD THE APP:
comments