Bias in code reviews
Do you feel like your code reviews are harsher because of your gender? Perhaps more nitpick-y? Adding more context: I am adding to an existing codebase and my change parallels the change a male sr developer made. Male developer: Here is how I tested my code. Please review. Reviewer: LGTM Me: (For a similar change and similar testing) Here is how I tested my code. Please review. Same reviewer as before: Wonder if this works as expected. Can you please do double the testing? Me: 😡😡😡
Received
Not saying no, but code review culture is highly localized in my experiences. Finding reviewers who can restrain from weighing in based on personal preference vs. those who want you to feel like they can help you make your code better is always disproportionate.
OMG. Why do people think so much about gender.
Considering I think abt it 5/365 days of the year, that's pretty good all things considered.
The definition of racial/gender/heterosexual privilege is literally that you "don't think too often about your racial/gender/heterosexual identity". This is why people "think so much about gender", it's because they likely do not have as much gender privilege as you. Fucking educate yourself...
It was harsher because the reviewer was protecting his own promotion project. Conflict of interest.
Good to put things in perspective. Reminding myself to be thankful for the one reviewer helping solve the issues...
if you don't argue and just keep on changing as per code review u'll keep on getting more comments. Once start arguing, of course has to be logical, it will stop and u'll be respected for ur thinking. Some micro manage type u should just ignore. I hate when someone comments 'nit' when similar nit are everywhere in the code to begin with.
Yep I feel the same. I feel I am asked a billion questions before I do something, while I am doing it and after. Constantly looked at with distrust. Hmph! Also my code review comments are dismissed more easily
Sorry to hear that!
If your code review comments are ignored. Ask them to not put you on reviewer list since you do not want responsibility. Also, tell them to not ask you to review from next time. I did this once several years ago. Coder to Manager: She is refusing to review my code Manager to Me: Why? Me to Manager: I don't want my name on this kind of code. Manager to Me: Really? Let me see. Next two days, manager spent pair programming with coder and teaching him how to do careful coding and said, he needs to get code reviewed by me and incorporate my feedback.
Is this happening with a particular review, or with everyone on your team? Is there someone you trust on the team (or manager?) that you feel comfortable discussing this with? It's hard for anyone here to give you a great answer because none of us have spent time getting reviewed both as a male and female engineer. So I wouldn't know if the other gender is being treated more or less fairly. But I can bet that if there is sexism going on, it would be with a minority of peers, not the majority. So that can give you an indication of if you are being treated unfairly or not.
Thanks FIRc11! There was just one reviewer in question and he was probably just trying to be really thorough, just it bugged me because he had previously let a male sr swe pass without the same thorough testing. I just pushed the code and let it go.
I’ve experienced the same. Just roll with it IMO. If there is merit to the critique, change your code. Otherwise just state your reasoning why you’re not going to take their critique and ask for other reviewers.
You mentioned the male is Senior. Are you? If not, you can expect more of a review. Are you newer to the team? If so, you can expect more of a review. Engineers on decent teams do good code reviews and care. Just merging things in LGTM is a sign of a bad team if that’s consistent. Be grateful that your coworker cares and find out what you can do to make him trust your work more. Develop your relationships with coworker engineers to gain trust => $$$$
No. Anybody who does this has bigger problems.
Thanks. I asked the reviewer for a 1-1 chat tmrw.
Need to figure out the right phrasing. Thinking something along the lines of "This made me feel singled out..."