When you have a change to submit, you must get an LGTM from someone familiar with the codebase and your work. And code reviews at G are normally pretty tough: people read every line and suggest better code practices or even design improvements. So you can imagine the review phase can sometimes take more time than implementation.
But getting LGTM is not enough. You must get a so called Approval proclaiming that your code conforms to the official G style guide for the language you've used.
And such an Approval can only be given by a person who has a readability in that language. A bit less often than always a person who you send your code review to in order to get an LGTM, and the one who has readability are two different people.
Sometimes the one with readability can be someone you know from another team, or there's even a default alias you assign the code review to which finds a random person with readability across the company to approve your change.
So, you can imagine, that's a ridiculous pain in the ass, which significantly slows down your performance with endless nit-picks and follow ups for older diffs, that you've already used for your next changes that are also already in review.
Now, you're likely asking me how would one get that desired readability and avoid all that amazing crap?
First, you gotta get into the line of similar noobs and wait for a few months only to enroll into the program. Then you should submit anywhere between 10-20 diffs over the course of yet another several months. Every such diff must be LGTM'ed and Approved by someone, thus be technically ready to submit. But you should restrain from the temptation of submitting it right away, but send to a special random readability reviewer.
There're anywhere between 5-30 of such reviewers per each programming language across the company. Serving as a readability reviewer is a huge privilege and is considered almost like a 20% project. People even mention that in their periodic performance reviews. But unfortunately, those chosen ones are often pretty busy engineers too, so you gotta wait for them for at least a day on average.
And have no doubt they won't approve you change w/o any suggestions. No, you're gonna struggle through and fix all the nits they're gonna find. And God forbid you argue with them. Because for every diff they approve you get some points. And btw, you must collect 5 points in 5 different categories to be considered for graduation. So, if you decide to argue with a readability reviewer, he can take off some points from you at the end of the review. Yeah, baby!
But anyhow, if you manage to overcome all the incredible unbelievable BS, you'll be granted that cherished readability, and you'll be able to submit your diffs with only one LGTM from a teammate. Yay!
OMG that sounds like heaven. I hate being the only one on my team that values code consistency, and constantly having to nitpick every review with coding style issues. We even have a formal coding guidelines, and yet no one on the team gives a shit and everyone just does things their own way.
Everyone here loves big companies huh. I feel like there are some breakout startups that'd maximize career capital better. Robinhood, Coinbase, Slack, Cruise just to name some. Maybe that's just a different focus than most people want