Whenever i raise a PR and ask my peers to review it, i get few silly comments like change the casing of letters in alert message, or there is too much validation of a variable, and other nit picks. They also mention it in the comments that they are nit picks. And its not like there was a rule on these. Because nothing would be mentioned about such things in user stories, i decide on what i think looks good. Also when i ask them about the comment or like the importance of the change, their reply would be “oh i just commented because i thought it would look good, but thats just my opinion” So i have 2 questions: 1. Is it that, at the end of the year one will be assessed on how many comments one has given in others PR,, because this just seems like they want to increase their count of comments and they usually do not have a logic behind their comments 2. Should I be worried that i am getting these comments, because will i be assessed on this. If yes, then im sure i would only be assessed on the number of comments on my PR and not the quality of those comments. (Right???) PS: I know i shouldnt even let this happen in the first place and so I should also focus on improving my code quality. Thanks #engineering #software #swe
They clearly state it’s a nit pick. Dont be weird about it
I think it's probably better to come up with a team agreed upon linter rule to solve these nippick automatically. Or have them submit the or for non functional change nit pick afterwards
India
Yesterday
446
Why do most Israelis still think India is "dirty and disgusting"?
India
5h
262
Why Modi not asking for votes based on work?
2024 Presidential Election
Yesterday
1105
Trump is practically destroying Biden at every poll.
Tech Industry
Yesterday
2426
Serious question: why are Indian marriages arranged?
Tech Industry
Yesterday
841
Bloomberg or Meta?
Reply to their comment asking them for documentation/feedback on why that change should be done. Guaranteed they’ll stop adding random comments when they’re asked to explain them in the PR
I like this one. will do it, thank you