Ex-FAANG engineer with 6 YoE. Worked with two companies/3 teams before joining my current gig. And I have yet to see how Code Reviews are anything less than soul-sucking, wastes of time. I don't know if the problem is me, or are Code Reviews generally meant to be exercises in nitpicking and political power-play where people just score brownie points/visibility ("Oh, look how many issues I pointed out! Look how many PRs I stopped from getting merged! I'm a vanguard of quality!"). On top of that, I rarely learn anything of substance from Code Reviews. If I have an architecture document which I have reviewed beforehand, I MAYBE could learn something in terms of how I can make better architecture choices, but Code Review comments frequently include banal, subjective crap like "refactor this into smaller functions" or "change this method name". 1. What have been your experiences with Code Reviews in your team? Are they substantial learning experiences, or just a check box you tick before merging, or a downright pain in the ass? 2. Have you ever left a team/company because of shitty Code Reviews that affected your Annual Review? 3. What are your techniques to deal with Code Review jerks? #engineering #software
Tech Industry
Yesterday
4029
What happens when most of your team is Indian?
AMA
Yesterday
1232
PM Manager, early 40s, married and ENM (Ethical Non Monogamous) AMA
Tech Industry
4d
27567
Can I slack off as E9 at Meta?
World Conflicts
9h
384
Is "From the River to the Sea" So Wrong?
Health & Wellness
Yesterday
960
Lasik cost
My team: When I write if else, they ask me to change it into ?: When I write ?:, they ask me to change it into if else. When I split a long method into smaller ones, they ask me why I need to split them. When I write a long method without splitting, they blame me that the method is too long. WTF is with those IDIOTS?
+1