Code Reviews
How does your company/teams handle code reviews? 1. Do you always checkout every branch and manually test that it looks right/works right/has no blatant regressions (assuming you also have automated tests in place, with decent but not perfect coverage) 2. Do you only review the diff and its code structure? 3. What do you do if the code seems fine, but their design seems off and needs reworking? At this point they've likely spent most/all of the sprint working on it already, and there may or may not be time to completely rewrite it. 4. How do you handle situations if they make code that does the job/fixes whatever it needs to fix, (it may even pass tests) but is just completely ugly and probably unmaintainable (e.g, spaghetti that would take significant effort to untangle) 5. Do you have a separate QA team that actually tests for regressions/correctness? 6. How confident are you/ how do you gain confidence that even your code comments are correct and the right way to build the app moving forward?
1. No, unless I was also working on it 2. Yes 3. So what, they shouldnl have cleared their design with the team/architect/peers 4. Leave that as feedback in code review, but i would be specific 5. Manual test vendors, rolling build+test runs 6. Code should be self documenting. Too many comments is as bad as too little. Use comments when necassary
π