What has been the dumbest or most stupid comment you received on your diff/code-review? I'll go first: Our VP (who sold his prev company for 100mil) left a comment on my C++ code to remove a macro that was used frequently because it put too much load on the compiler 🥴 #software #swe #engineering #diff #codereview
nit: What does this mean? Me: What do you mean by this? nit: I like X style instead of Y. me: I like Y. What's your point? nit: ? me: ??
😛🎃😂
Yup I’m guilty of that. Something about nested ternary operation just annoys me
I got a comment on the grammatical mistake in commit message. 🤦
my lead once said to me : why have you deleted all the files, you dumbf**k ??
I once spent 3 days realigning all TABs in a file because the reviewer didn't like the automatic code formating provided by the IDE. They files tens of comments because of spacing issues, not even a single line of code Wes reviewed for a whole week. Only blanks. I ended up switching from Visual Studio to Notepad because that was the only "IDE" the reviewer accepted.
U should have suggested the team adopt a code formatted that gets invoked during commit that automates style guidelines
That sounds horrible.
“A missing separator in multi-line comment makes the meaning ambiguous” —this was a comment on a comment missing a ,
“Redo”
I once asked someone to replace ++i with i++ in a for loop, because all other for loops in our codebase were i++
I had someone comment that the pr is over engineered and when I changed it to a simple approach even though I believed that the original approach was better, the same person "suggested" my old approach as if it's his own
😂
I had a spelling mistake of missing a letter in local variable name and used the same in actual usage. There was a nit comment to fix it which is okay. But then my dum***s manager who doesn’t have any technical knowledge working on code asked me to write unit tests to detect these spelling errors
rofl, should have strike back with something along "to integrate a basic NLP model in AST parser to detect a spelling mistakes will take 6 sprint of work, which I am happy to start working, putting all other work aside"
I had someone put my CR on waiting once because I had missed a period at the end of a comment.
😂😂
Nah, that's personal