Dumbest comment u received on your code review

What has been the dumbest or most stupid comment you received on your diff/code-review? I'll go first: Our VP (who sold his prev company for 100mil) left a comment on my C++ code to remove a macro that was used frequently because it put too much load on the compiler 🥴 #software #swe #engineering #diff #codereview

Microsoft zeCeo Oct 29, 2021

I had someone put my CR on waiting once because I had missed a period at the end of a comment.

New
kitty🐈69 Oct 29, 2021

😂😂

NVIDIA cfish01 Oct 29, 2021

Nah, that's personal

Datadog dpoehgg Oct 29, 2021

nit: What does this mean? Me: What do you mean by this? nit: I like X style instead of Y. me: I like Y. What's your point? nit: ? me: ??

New
kitty🐈69 Oct 29, 2021

😛🎃😂

TikTok pbGf36 Oct 29, 2021

Yup I’m guilty of that. Something about nested ternary operation just annoys me

Amazon amz100000 Oct 29, 2021

I got a comment on the grammatical mistake in commit message. 🤦

Facebook peace ☮ OP Oct 29, 2021

🤣🤣 this is unheard of!

Amazon amz100000 Oct 29, 2021

This comment I got from a seasoned amhole.

Flipkart zuckybucky Oct 29, 2021

my lead once said to me : why have you deleted all the files, you dumbf**k ??

BlackRock electrify Oct 30, 2021

Well? Why did you delete all the files?

Flipkart leavefk Oct 30, 2021

Idk man, wanted to make some impact.

Microsoft RadKandor Oct 29, 2021

I once spent 3 days realigning all TABs in a file because the reviewer didn't like the automatic code formating provided by the IDE. They files tens of comments because of spacing issues, not even a single line of code Wes reviewed for a whole week. Only blanks. I ended up switching from Visual Studio to Notepad because that was the only "IDE" the reviewer accepted.

Amazon happy19 Oct 29, 2021

U should have suggested the team adopt a code formatted that gets invoked during commit that automates style guidelines

New
kitty🐈69 Oct 29, 2021

That sounds horrible.

Amazon happy19 Oct 29, 2021

“A missing separator in multi-line comment makes the meaning ambiguous” —this was a comment on a comment missing a ,

HackerRank pathetic Oct 29, 2021

“Redo”

Microsoft isensei Oct 30, 2021

sad

BlackRock electrify Oct 30, 2021

Asserting his/her dominance

Amazon cbellMS Oct 29, 2021

I once asked someone to replace ++i with i++ in a for loop, because all other for loops in our codebase were i++

Shopify auc Oct 29, 2021

I’d do that for consistency 😄. High-five!

Amazon not amazon Oct 30, 2021

technically ++i is better, its a single instruction while i++ creates a buffer

Microsoft 凸(-_-)凸 Oct 30, 2021

I had someone comment that the pr is over engineered and when I changed it to a simple approach even though I believed that the original approach was better, the same person "suggested" my old approach as if it's his own

Microsoft isensei Oct 30, 2021

😂

Oracle morty's Oct 30, 2021

I had a spelling mistake of missing a letter in local variable name and used the same in actual usage. There was a nit comment to fix it which is okay. But then my dum***s manager who doesn’t have any technical knowledge working on code asked me to write unit tests to detect these spelling errors

Amazon not amazon Oct 30, 2021

rofl, should have strike back with something along "to integrate a basic NLP model in AST parser to detect a spelling mistakes will take 6 sprint of work, which I am happy to start working, putting all other work aside"