I find kinda hard to review PRs using the GitHub. Can't navigate around. Do you guys pull the branch and see what is going on or you all comfortable with the git diff?#engineering #software #swe #engineering
Depends on what kind of code and how big the diff is. Ideally, the diff is enough, and you can see the full file if needed.
When I use GitHub, I just use the native tools. You can switch the comparison difference to be side by side.
In a new code base for me, I pull down and run it to see what’s going on and learn, over time it’s easy to just do a GitHub review of the pr
Small commits + strong application-level tests give me the strongest confidence I agree, git’s diff/pr-review stinks.
I usually pull the branch, yeah. Not only am I faster at navigating around a git repo from the command line, but pulling the branch also allows me to actually explore the codebase, or even run some experiments and stuff, instead of just reading the code visually in the browser.
There’s a chrome extension, better pull review or something, it makes it a lot easier to see the changes file by file. I use that most of the time, but sometimes need to load the branch in an IDE to see what it’s really doing
If the diff is not enough then it means there are too many commits in that PR than it is supposed to be
Bitbucket is so much cleaner. I wish more companies adopted it
"LGTM, ship it 🚢"
World Conflicts
Yesterday
502
American police seem to work only when Israel is challenged
Tech Industry
Yesterday
3715
Crossed a line with my boss
Tech Industry
4h
962
How common is it actually to earn more than 300K TC?
Tech Industry
8h
2031
Asians - what are your thoughts on asian female white male ?
Tech Industry
Yesterday
2804
I am starting to think Chinese interviewers currently fail non-Chinese candidates on purpose.
using ChatGPT obviously.