a coworker just merged his PR without a review. What should I do? Keep the secret? Bring it up at a retrospective or standup? @here him on slack?
Wow
Call police
Are you above him/her in terms of position? If above, talk in-person first. If same or below, you can “ask” about it on group slack
Depends, usually its ur leaders responsibility to create a code pipeline that guarantees quality. If you CAN merge code without review, its safe to assume leadership is OK with this?
No its not generally OK. There is an option to override with admin privileges which is what he just did
So he's an admin and has been granted permission. Honestly I've done it a few times. Really small team, asked for reviews, nobody looked, eventually I merged it. We do test builds against the PR, so it's not like it was broken or anything
Merge one behind his back as revenge
Create a new pr that reverts all of his changes and send it to him for review
This is what I did. He looks very upset.
This is very aggressive behavior. You should’ve talked to him. People will forget what you do or say, but people will never forget how you make them feel.
How bad is it? If he’s setting a backdoor, report and scream. Just fixing white spaces, stfu.. anythiny in between, use your judgement (assuming you still have one, since you’re complaining about it here 😂
Simple. Revert the changes.
I’d be more worried something breaks
Serious?