I had a coworker, whose code is disgusting. They have been working for 15+ years, and their code is the worst I have ever seen in my 7 year career. I don’t know exactly why their code is making me uncomfortable, but they have a lot of >500 line functions, and a lot of nested if-else, of which the conditions are random. Each if condition could be >20 lines long. How they managed to debug their own code is a mystery to me. They were level 4 (or software 2) when they still in my team. Now they switched job, and landed as a level 6/7 in the new company. I feel terrible if some junior engineers were coached by them.
Which new company?
You mean the boolean statement inside the if is 20 lines long!? 😵
If that's the case, that's some real skill the guy has :p
yes, that’s right. they are that style always.
Experiencing the same thing. Do you know if there's a best practice guide for refactoring python code?
Job security, brah, obfuscation.
Any resources to improve?
I would rather one long function that something that jumps all over the place with function names that don't really mean anything. But yes, I have seen a lot of disgusting code, and you can review it, but sometimes it's so bad you don't even know what to say.
I don't have +2 permission on anything, so definitely not
That happens lol
I know. I need modify their code recently, and I am reluctant to work every day. Maybe I should talk to my manager. Don’t know how to say it in a polite way.