When do you have to give this code review interview? I recently did phone screen for L6 and in that they asked me to review and find bugs in some complex probabilistic code. I wasn’t aware I’m going to be doing anything of such sort, recruiter told me that it was going to be a pure coding interview. So, wanted to know if it’s common to get code review interview as your phone screen. I felt bad that I failed the screen but also felt, I could have done it much better if I had known about this and I would be in appropriate mindset for debugging a code.
I am doing this as part of a full loop
Thanks, is this for EM role?
Is this something new?
Nothing to do to prep. Did this a couple months ago as long as you can read code and know what good code is supposed to look like you’ll be fine. The code I reviewed was horrible so there was a lot to talk about.
India
Yesterday
631
'Hindutva': The Radical Hindu Ideology That Seeks to 'Push Christianity Out of India’
World Conflicts
Yesterday
495
Is "From the River to the Sea" So Wrong?
Tech Industry
Yesterday
323
Family of 3 travel to India
Personal Finance
Yesterday
1068
Thank you AAPL and NVDA
World Conflicts
Yesterday
429
Why I Find Free Palestine Inspiring
I did this recently. You first just have to go line and line and comment what is wrong like codestyle is not good, algo is not efficient, edge cases not handled, incorrect syntax, no unit tests. Afterwards I added unit tests to it, and then used it to explain the edge cases not handled. Then finally suggested ways to fix it, and why the algo was better but not fully implement the fix. It’s pretty much LC easy except you don’t have to implement the full thing but in the end you kind of do, but more focus on explaining and finding the existing issues from someone else’s “bad solution” to that LC easy solution instead of coding it all up yourself from scratch.
Where do you add unit tests? Is this exercise done using an IDE? Or do you mean test cases (input and expected output)?
Used google docs, so it was more pseudo code than real code although I did mostly real code but there was no running of the code. Just mostly discussions about it.