How is FB codebase?
Recently received an offer from FB. I'm a full stack engineer with stong react and Java knowledge. I know FB is based on React for web and Hack for backend. Would like to know how is the standard of the react and Hack codebases. Do you have good tests, coverage report and coding standards? How is the review process to get the PRs merged? T.C: 160K YoE:3
Fb also uses plenty of c++ for backend if you'd like to learn that
Interesting. I'm working on C++ code as well here. Though not very strong, I'm comfortable.
If you're coming in as E4 or E3 teams don't care if you don't know the language. As long as you learn fast. I just went through bootcamp for Facebook... Paired with 2 teams using hack, one team using c++
Yes, test coverage is good and quality is above what you’d expect from what people say on the outside.
Thanks for the info Google. Do you work at FB?
Code review is usually pretty fast. We care a lot more about metrics and logging than test coverage. Usually something has to break before we implement tests. Almost nothing is documented. Join Facebook if you want to move fast and ship lots of features. Don't join if code quality is your #1 priority.
How strong is strong?
Atleast the quality is above average. I have seen shitty codebases at PayPal. One example is not following single responsibly principle.
Alright! All the best for your new role. Usually codebases are crappy. Even if you write it to the best of your capability, the next developer working on it would 'fix' the code.
What’s the offer you got ? And which level in Fb ?