Quit after first day?
So I’m hired as a React developer and the pay is really good. I’m still a student but have a lot of experience with JavaScript and React. The codebase is garbage and they have really senior engineers working on the same project. I got so mad seeing that codebase. They are not following standard practices and merged so many commented code into master. Is it okay if I raise this up or will they hate me for life? I’m still a student thou but after looking at the codebase I have more experience then some of the developers there. Should I just shut up and work ?
😒
Welcome to the real world
Depends on the company and your personal relationship. You’re new, so maybe you can phrase it as a “hey, looking as an outside, this looks like a problem”.
Don’t be too straightforward as you might offend some seniors. You are going to need them for guidance since you are new. A better way to put it in meetings is, “I have been looking through the code and see that a few things can be improved or done in a different way”. Constructive feedback is always appreciated.
They will hate you . Most likely. I was in the same situation few years ago. Totally mad at the codebase and architecture. I proposed tons of improvements. I could finally push only one of my proposals. Politics comes into play. Fight for survival comes into play. Other people in the team will make it harder for your importance felt otherwise they lose relevance. We have a senior QA engineer in our team who doesn’t even know coding. Not even a computer science guy. But since he is the manager’s right hand, he proposes many bullshit and that is accepted by the manager. And no one disagrees with the manager. This QA guy will also object to my codebase /architecture suggestions citing bullshit reasons. Now I have become like them. I write shitty code. :D
Oh no! That's not good. I didn't expect it to end that way.
Unfortunately in corporate world a “yes man” who also has the capability of licking peoples ass has more chance of survival.
You’re experiencing the industry for the first time. I’m glad you get to realize why school/grades mean very, very little in the real world. Quit, but if you still decide to be a software engineer after school, you’ll realize that all you did was defer your experience.
Lol. Wow. Get a thicker skin.
It’s like this anywhere you go. Raise a few questions and ask them why it is done this way and why not another way. See what they say. If it makes sense, then you will understand. If not, then come up with a proposal on how to make it better.
No this is not how real world works... commented code is rare unless you plan to reuse in near future. You should run
Microsoft is not the real world. Nor are any of the FAANGs, and even those have these issues. Most of the world is run by code monkeys written in some village somewhere in India or Russia.
Well microsoft does have offices in multiple places... so it is close to real world. Everything depends on the team and how maintenance/reliable you want your service to be
I hate to say this, but that’s how most companies work.