Screwed up: Stay or leave?
So I am a new grad and have been working for around 6 months. My team doesn't own any service but works as a away team. I accidentally pushed buggy code twice for the same feature, the service is owned by away team. (In my defense, both times my CR were reviewed by couple of SDE 3). Currently, my manager doesn't know about it (Actually, I don't really have a manager. My ex-manager left couple of months ago and in the meantime my skip has taken over. But, she is not very hands on, doesn't attend stand-ups, never had a 1:1 with etc). Also, my skip doesn't know about my pushing the code changes and is on a work trip, won't return till the end of next week. I believe if my skip finds out about it, there is a high chance that I might get dev-listed. Also, I believe I can find another team within a week. I know, at this point I sound like a coward but I really want to save my ass. Should I try to find another team and leave or stay and work hard and try to improve my impression? I would like your advice in this situation, instead of yes/no answers. So,.not creating a poll. Any advice would be greatly appreciated.
Get the fuck out before Jeff sends those ? Emails to you.
Lol, I am assuming you are not trolling by asking this question. I have worked at Amazon, so I could take a stab at it. Either it is non-critical, in which case no one cares, or it is. If it was critical, ideally there should have been COE or some action item taken the first time. As you said, you accidentally pushed the code, meaning there were not enough checks in place for the code that you were pushing in. This should be an action item on the team for which you checked in the code. Ultimately, it should be the process that should be questioned, not the person. Sure, if you make same mistake 2-3 months down the line, then your manager might point it out. Otherwise, I would say keep learning from your mistakes, and do take a chill pill. :)
I agree, expectations are not as high as you think for new grads first 6 months @yungAmazon. However, I'm pretty disappointed hearing his skip manager experience. Though based on dev list being his first assumption, he might just be having trouble asking what he might need from her.
Thanks. No I am not trolling. By accidentally, I meant I did not perform enough manual testing before pushing the code.
Regardless of what you decide,,, did any of the senior devs catch the buggy code at either time during code reviews? Were they aware of the previous buggy push? Someone would know to look for that same issue? Can you add more tests to prevent a 3rd buggy push? Are you rushing? Is there a trusted coworker you could confide in to get advice from?
Thanks for the reply Did any of the senior devs catch the buggy code at either time during code reviews? No, that's why they gave the approval. Were they aware of the previous buggy push? The second time they were aware of bugs in first. Someone would know to look for that same issue? I guess, but not sure. I am the only person from my team working on this issue. Can you add more tests to prevent a 3rd buggy push? Yes. Are you rushing? Yes, we have a launch coming up. Is there a trusted coworker you could confide in to get advice from? I think so but would rather not. That's why asking advice on Blind
I may be preaching to the choir here, but just remember that seniors won't have more context than you about changes you make and that you shouldn't expect them to catch all code incorrectness that may not be readily visible. They'll be more for general advice and blatant issues, and this is how CRs go for SWE in general. Drill yourself on being thorough at every step, but don't expect yourself to have the best dev habits in 6 months either: you can fall and not fail. Definitely figure out someone you can talk to as a mentor outside of your org, though, blind will give you significantly worse advice than them. Good luck with your launch!
Fix it and then move on. Fixing it is important for your own benefit in the longer run. Move on because the way you described your team, it doesn’t seem to be a place that will help grow a young engineer to be a better one.
Thanks for the advice.
I fucked up once really bad. Like really really bad. Almost had a heart attack (no joke). First I called the team lawyer. Then I called my manager. Then we consulted with our L8. They appreciated how I handled it all, has not happened again, and nothing really bad resulted. A few months later I got promoted. Have some balls. If I was you I’d show character and some dignity. Running from your problems is not sustainable.
I always wish we could hear the details of war stories like these without giving away anonymity
It’s unreal.
LOL, dude bugs are everywhere. The most important thing is whether you own it or not. Fix and move on, no big deal... Learn from the mistakes. Grow up.
Thanks for the reply
You Amazon, you should always look for new jobs whether you make this mistake or not.
You want to join G and F anyway.
Just trying to survive in this case. Don't want a new job right now