I have some coworkers that will nitpick a cr until it’s on its 10th revision. Is this productive, why do people do this?
We need examples to judge...
They need platform to show how awesome they are.
This. This is one place power goes unchecked in a completely subjective environment. Assholes flourish.
Write better code and you won't have this problem.
It’s hard to come up with specific examples, but like when people complain about your variable names, or the way you wrap code or just little things that boil down to programmer preference that they disagree with.
Push back. Establish checkstyle rules. Demand objective reasons for changes, and then point out that Amazon has already spent more money on this code review than a switch statement that uses jump under the hood will ever save over a series of if statements.
This is why open and consistent style guides, and automatic linters are import.
This is Amazon. Your team is preparing data to help your manager PIP you next year. Please leave asap.
Lmao lost it
I wish I had code reviews from assholes tbh - provided they aren't incorrect issues.
This is the flip side of it. Not getting code reviews at all so no growth.
People generally get stuck in their ways and think their way of writing the code is correct and more readable for them. Be wary that it might be you who needs to change too. In general, follow the pattern in class (package and so on) to avoid nitpicks.
In MSFT I see this typically happening when you make changes to code that some other team owns.. The pattern and style generally differs across teams..Rather than arguing which way is right, I typically follow the principle when in Rome be a roman to push my changes.. There are lot of editor plugins available these days to catch the drift in styles during development and code analysis tools as well.. Good to integrate them with your build systems to catch these kind of issues upfront.. I have personally witnessed the quality of pull request have improved post that.
This ^ locally consistency is important. Don’t bring your style opinions into someone else’s house.
Being prickish about CRs is two birds with one stone at Amazon. 1) it shows your Insists on Highest Standards while you have the work done by someone else. 2) It prevents your teammates Deliver Results, making you look better in comparison. The company wants us to do this, learn it.
Some folks do to avoid merge conflicts :p
The 2018 SO dev survey stated that there is a direct correlation between the number of times a dev checks in code per day and their happiness.
Because you work at Amazon