How does code review and writing tests work at Facebook? Are these 2 mandatory? Personally I hate them and they make the entire process too slow. Ppl start nitpicking on useless issues, take a long time to get approval, and overall just prevent u from GETTIN SHIT DONE. “Just ship, and fix if problem aries” has always worked in my experience, even for large user-facing projects. Plus you deliver 3x-5x faster, beats off the competition.
Tech Industry
Yesterday
2341
I do tech screens at Google. AMA
India
5h
1886
Why is it so G*damn difficult to move money out of India
Health & Wellness
3h
466
Issues with sleep
Cars
Yesterday
1206
Cyber truck killer: Chinese version of EV truck
Tech Industry
3h
394
When was the last time you had to take a piss test for work?
Reviewer yes, unit test not required
Thank god you don’t work for Boeing ✈️ ☄️💥🔥
OP I think you will fit in well at Facebook :)
is code review part of promo pack tho? how can the engineering quality point be ticked at fb? heard its one of the criteria
You need to find a balance between quality and speed, not to just 100% give up on code review and tests right?
that's my question, but unfortunately a lot of American firms blindly test everything
It seems like you don't understand why unit tests exists. This is a problem when you hire someone who only does leetcode without knowing anything about basic software engineering.
There are a lot of things I like about fb, but Gettinf shit done philosophy to avoid writing tests is the worst, how much times does it even take to weite a unit test for gods sake.
It’s not hard at all. There you go. I wrote one for you: @Test public void cambrigeAnalyticaGetsDataEvenWhenUserConsentFalse() { bool userConsent = false; service.sendDataToCambridgeAnalytica(data, userConsent); AssertEquals(service.readFromCA().data, data); }
I will do the code review on that: "Dude, you forgot to pass userConsent to the service!!!" as you can see, both test and code reviews are needed!
Almost spit out my coffee reading this 🤣 🤣 🤣
Who said Facebook doesn't require code reviews?
If your service is deployed to 1000s of nodes in a region, a single deployment can take a couple of hours, at least. 2 hours of customers seeing 500s is a massive loss of revenue for a web service company (Azure, AWS, GCP). Thorough testing, documentation and review are needed before deployment.
Why would adding a new emoji reaction every year need tests? You can move very fast and “break” things.
even when heavily tested things still shit the bed
You’re too confident kid. Wait till you break something and cause multi-million dollars of lost revenue due to this overconfidence. If you don’t work on revenue impacting service, then go do what you want. No one cares much.