saying "thanks" when approving code?
we have a guy that when he reviews code and approves it, instead of the usual "lgtm", he'd write "thanks!". Do you do it? Is this weird and what is he thanking for? To add to the confusion he's the newest member of the team and half of the stuff he approves don't even make sense to him. Maybe he's thanking for the chance to let him study the code?
How about you ask him instead of asking on blind?
that'd be even weirder than him lol
I frequently thank people for contributions, I think I do it when they do general goodness and not feature work (Fix bug, refactor, cleanup, improve documentation, ...)
yeah cleanups I totally understand. But he just thanked me for a new feature 🤣 It's almost as if I made the feature for him or something.
Maybe he is a user of your product and he really wanted that feature?
You work with a nice guy. You should appreciate it and not question it.
I usually question when people are too nice. Thanks for your kind comment and have a good day! 🥰
Never seen that before. Do they excessively say thank you for other things? Maybe they’re incredibly oblivious to the CR tool/process and he thinks he’s thanking people for reviewing his code?
Bloomberg ppl are weird af! Looking at you OP!
much better than a "thanks but".
Learn some courtesy first.
Canadian?
I had to Google what LGTM meant. But ok. Do I do it? No. Why he is doing it? Only he knows. May be because you added him as reviewer. May be ask the guy who does that.
If I added him as reviewer then I should be thanking him for reviewing my code right 🤣
Thats right. I thank when someone approves and merges or adds comment to my PR. Definitely not when I am added as reviewer.