Im new to the team and I always get a great amount of comments while creating PR. Even if I copied the same pattern that was previously implemented. Most of the comments are from my teammates( the ones that wrote those patterns). Is this a kind of bullying?
“I modeled this code off of the code here: <url to PR>. Should we make the change there as well?”
Well if you are copying bad code that gives no justification for continuing to write bad code :) past is past , maybe the expectation for future is better
Presumably it’s not bad code if the person critiquing the code in the PR is the person that wrote the code thats being modeled after.
Same here, my latest pr(about 300 lines) has over 60 comments.
Appreciate that someone cares about the quality of your codebase and is taking the time to look and give feedback on your code. They could use the time to work on their own stuff, build new features to get themselves promoted. Instead they spend the time helping you write better code. Why is this a bad thing?
have you ever looked at your own code written one year ago?
Your PR is too big
Do you get offended by those feedback comments ? Did you talk to them directly ?
never I always be in a good attitude. But I noticed a pattern and some of them I feel exaggerated
Do bring this up with them 1:1 and share your concerns , people love direct feedback and they will support you in your growth.